Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team6 #156

Merged
merged 12 commits into from
Sep 12, 2023
Merged

Team6 #156

merged 12 commits into from
Sep 12, 2023

Conversation

rahulsagar500
Copy link
Contributor

  1. Added Background for MainMenu
  2. Added DragAndDrop
  3. Added PopUp for DragAndDrop
  4. Added GameOver PopUp after health becomes 0.

@rahulsagar500
Copy link
Contributor Author

  1. Added Background for MainMenu
  2. Added DragAndDrop
  3. Added PopUp for DragAndDrop
  4. Added GameOver PopUp after health becomes 0.

@rahulsagar500
Copy link
Contributor Author

  1. Added Background for MainMenu
  2. Added DragAndDrop
  3. Added PopUp for DragAndDrop
  4. Added GameOver PopUp after health becomes 0.

@rahulsagar500 rahulsagar500 reopened this Sep 12, 2023
@rahulsagar500 rahulsagar500 merged commit 477f2d6 into main Sep 12, 2023
@Jonoym Jonoym mentioned this pull request Sep 12, 2023
Copy link
Contributor

@The-AhmadAA The-AhmadAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The game over functionality in particular is redundant and covered by other task tickets. Please disable this so it does not interfere with game over funcitionality

private static final float Z_INDEX = 2f;
// Dialog for displaying tower details

private Vector2[] towerPositions1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear what is happening in this method. What are all the tower variables here for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just a structural design for our functionality of drag and drop, we will integrate it with the real entities for the upcoming sprint

for (int i = 0; i < 2; i++) {
// Use "building1" for the first tower and "building2" for the second tower
skin.add("default", new Label.LabelStyle(new BitmapFont(), Color.WHITE));
skin.add("building2", new Texture("images/towers/turret_deployed.png"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this "turret_deployed.png" image is no longer being used for anything in game

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for that, We worked in our remote rep, changing that now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The game over functionality is already covered by ticket #132 and #80

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @The-AhmadAA this feature was our task for team 6 and we did discuss this in the studio standups as well. The only problem was that we did not know the condition of the game over yet and forthe time being assigned the screen visibility when the health of player becomes 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants